Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable graph node manager tests #15184

Merged
merged 1 commit into from
May 1, 2024
Merged

Re-enable graph node manager tests #15184

merged 1 commit into from
May 1, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Apr 30, 2024 •
edited
Loading

Purpose

Given master-5 can now run tests, try to re-enable these tests to see if they pass

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

zeusongit
zeusongit approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@zeusongit zeusongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to pass, but harmony scan failed due to an unrelated error.

@QilongTang
Copy link
Contributor Author

Tests seem to pass, but harmony scan failed due to an unrelated error.

Thanks, tests also passing at https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1436/. Since Morpheus team did not fix this specifically, I suspect this PR #15159 helped.

@QilongTang QilongTang added this to the 3.2 milestone May 1, 2024
@QilongTang
Copy link
Contributor Author

QilongTang commented May 1, 2024 •
edited
Loading

@zeusongit @reddyashish I am going to merge this and trigger master build to confirm if the tests are back passing on release pipeline

@QilongTang QilongTang merged commit 9cb740c into master May 1, 2024
22 of 23 checks passed
@QilongTang QilongTang deleted the Re-enableTests branch May 1, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeusongit zeusongit zeusongit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@QilongTang @zeusongit